Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
@LaurentGoderre I'm not sure what you mean, the template files are all |
LaurentGoderre
dismissed
their stale review
Oh yeah, you're right, I forgot about that part. Sorry about that
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/en/blog/release/v7.9.0/
Not sure if anything else is needed?
I tried to run
update.sh(just./update.sh 7.9.0), but that did nothing, so the changes here were done manually. Maybe a CONTRIBUTING.md should be added?EDIT: Doing
git mv 7.8 7.9; ./update.shworked. Should the directories here be just major and not minor? Can be discussed in separate issue, I suppose. EDIT2: #322